feat(score-card): New config jsonNameOfAllEntities #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @A11oW, so sorry I missed your suggestion. There was (and in fact still is) an issue with PR notifications for this repo, got overwhelmed and also there was no reason to check the repo for a long time. try to ping me next time, it should help :) Regarding your contribution... is this something you still wish to merge? There is some ongoing parallel work so we shall release a new version soon, with your changes included. WDYT? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new parameter through which you can set the file name for all entities. In my environment.
I use gitlab for hosting score data and I plan to receive data via gitlab api (for cors to work). My work full url like this: "https://gitlab.local/api/v4/projects/6242/repository/files/all.json/raw". How can you see url have postfix /raw in my case
It seems to make it possible to make the name "all.json" customizable would not be superfluous
✔️ Checklist
yarn changesetin the root)